Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): initialize TS support in Vue files #14212

Merged
merged 9 commits into from
Jan 28, 2025

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

🖌️ UI Checklist

🚧 Tasks

  • ...

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

src/components/PollViewer/PollEditor.vue Outdated Show resolved Hide resolved
src/components/PollViewer/PollEditor.vue Outdated Show resolved Hide resolved
src/components/CallView/CallFailedDialog.vue Outdated Show resolved Hide resolved
src/components/PollViewer/PollEditor.vue Outdated Show resolved Hide resolved
src/components/ImportEmailsDialog.vue Outdated Show resolved Hide resolved
src/components/PollViewer/PollEditor.vue Outdated Show resolved Hide resolved
@Antreesy Antreesy force-pushed the fix/noid/typescript-support branch 2 times, most recently from 342f83f to c85ffc0 Compare January 25, 2025 10:51
@ShGKme
Copy link
Contributor

ShGKme commented Jan 28, 2025

I have a very weird error, which doesn't make sense - the types are correct here.

Don't you have the same?

$ npm run typescript:check                 

> talk@22.0.0-dev.0 typescript:check
> vue-tsc --noEmit

src/stores/breakoutRooms.ts:119:32 - error TS2353: Object literal may only specify known properties, and 'activeTab' does not exist in type '{ cache?: boolean | undefined; }'.

119     sidebarStore.showSidebar({ activeTab: 'breakout-rooms' })
                                   ~~~~~~~~~


Found 1 error in src/stores/breakoutRooms.ts:119

src/services/coreService.ts Outdated Show resolved Hide resolved
src/utils/getDisplayName.ts Outdated Show resolved Hide resolved
@Antreesy
Copy link
Contributor Author

Don't you have the same?

I see it in the file, but not during automatic check 🤔 Maybe it's due to that type is inferred from .js file

src/reset.d.ts Outdated Show resolved Hide resolved
@ShGKme
Copy link
Contributor

ShGKme commented Jan 28, 2025

Don't you have the same?

I see it in the file, but not during automatic check 🤔 Maybe it's due to that type is inferred from .js file

It infers type from JS definition incorrectly.

Either migrate the module to TS or add JSDoc with types:

/**
 * Show the sidebar
 * @param {object} payload - Action payload
 * @param {string} [payload.activeTab] - Tab ID to open in the sidebar
 * @param {boolean} [payload.cache] - Whether to cache the sidebar state in the browser storage
 */

Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
- sourced from Talk Desktop

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
- sourced from Talk Desktop

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/noid/typescript-support branch from e24e6a2 to 8ff3673 Compare January 28, 2025 15:07
@Antreesy
Copy link
Contributor Author

  • rebased
  • migrated sidebar.js to .ts
  • fixed coreService.ts
  • fixed typos

@Antreesy Antreesy merged commit 456277e into main Jan 28, 2025
79 checks passed
@Antreesy Antreesy deleted the fix/noid/typescript-support branch January 28, 2025 15:24
@Antreesy
Copy link
Contributor Author

/backport to stable31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants