Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bidi): adjust UI to RTL support #14163

Merged
merged 9 commits into from
Jan 27, 2025
Merged

fix(bidi): adjust UI to RTL support #14163

merged 9 commits into from
Jan 27, 2025

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Jan 20, 2025 •
edited
Loading

☑️ Resolves

Hint: link the latest version of upstream to include the NcListItem RTL fix

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

So many changes (hence so many pictures), please feel free to checkout the branch and navigate :')

🏚️ Before 🏡 After
Screenshot before image

🚧 Tasks

  • Call view adjustments (follow-up)
  • Not tested (blind change): bots, chat summary

Things to be fixed upstream:

  • NcAvatar status icon is fixed on the right side only
  • NcAppNavigationLink

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad DorraJaouad self-assigned this Jan 20, 2025
@DorraJaouad DorraJaouad changed the title fix(RTL): adjust UI to RTL support fix(bidi): adjust UI to RTL support Jan 21, 2025
@hamza221 hamza221 self-requested a review January 21, 2025 13:55
Antreesy
Antreesy reviewed Jan 21, 2025
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked a first batch (32/48 files 🫠 )

src/components/AvatarWrapper/AvatarWrapper.vue Outdated Show resolved Hide resolved
src/components/ChatView.vue Outdated Show resolved Hide resolved
src/components/ConversationSettings/ConversationPermissionsSettings.vue Outdated Show resolved Hide resolved
src/components/ConversationSettings/LinkShareSettings.vue Outdated Show resolved Hide resolved
src/components/ConversationSettings/Matterbridge/BridgePart.vue Show resolved Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessagePart/FilePreview.vue Outdated Show resolved Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessagePart/Poll.vue Show resolved Hide resolved
src/components/NewMessage/NewMessageAbsenceInfo.vue Outdated Show resolved Hide resolved
src/components/RightSidebar/Participants/Participant.vue Show resolved Hide resolved
src/components/RightSidebar/Participants/ParticipantsTab.vue Show resolved Hide resolved
@ShGKme
Copy link
Contributor

ShGKme commented Jan 21, 2025

Rebasing on #14169 will enable auto-fix (that still should be checked) and make sure we always use logical properties.

@ShGKme ShGKme mentioned this pull request Jan 22, 2025
Merged
9 tasks
@DorraJaouad DorraJaouad force-pushed the fix/noid/rtl-support-talk branch 2 times, most recently from 1d7b095 to 4b99314 Compare January 22, 2025 14:31
@DorraJaouad DorraJaouad marked this pull request as ready for review January 22, 2025 14:37
ShGKme
ShGKme reviewed Jan 22, 2025
View reviewed changes
src/assets/markdown.scss Outdated Show resolved Hide resolved
src/assets/markdown.scss Outdated Show resolved Hide resolved
src/components/ConversationSettings/ConversationPermissionsSettings.vue Outdated Show resolved Hide resolved
src/components/LeftSidebar/LeftSidebar.vue Outdated Show resolved Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessagePart/MessageBody.vue Outdated Show resolved Hide resolved
@DorraJaouad
fix: margin-left
d0103af 
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
@DorraJaouad
fix: cleanup old styles
a98d7c1 
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
@DorraJaouad
fix: margin-right to margin-inline-end
64c78a9 
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
@DorraJaouad
fix: padding-left to padding-inline-start and padding-right to paddin…
683a1d7 
…g-inline-end

Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
@DorraJaouad
fix: clean directions in general (I lost control)
087aa3a 
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
@DorraJaouad
fix(NcRichText): adjust the direction of interactive items
4fe885e 
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
@DorraJaouad
fix: post-review changes
eb4a015 
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
@DorraJaouad
fix: ignore logical properties rules temporarily in call related comp…
49a4e66 
…onents

Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad force-pushed the fix/noid/rtl-support-talk branch from b4e26ef to c90e20b Compare January 27, 2025 09:56
Antreesy
Antreesy approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of a last commit, but as long as you're not jumping from one lang to another, should be fine

@DorraJaouad DorraJaouad force-pushed the fix/noid/rtl-support-talk branch from c90e20b to 49a4e66 Compare January 27, 2025 14:16
@DorraJaouad
Fix(NewMessage): adjust items dir based on the selected language. It'…
4a1c64f 
…s temporary until we find a way to fix the emoji picker on selected language and not on user's language (new text message)

Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad merged commit 7124e61 into main Jan 27, 2025
50 checks passed
@DorraJaouad DorraJaouad deleted the fix/noid/rtl-support-talk branch January 27, 2025 15:14
@DorraJaouad
Copy link
Contributor Author

/backport to stable31

@backportbot backportbot bot mentioned this pull request Jan 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme left review comments

@Antreesy Antreesy Antreesy approved these changes

@hamza221 hamza221 Awaiting requested review from hamza221

Assignees

@DorraJaouad DorraJaouad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DorraJaouad @ShGKme @Antreesy