Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(signaling): add UI warning in call with 2+ participants #14022

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Dec 18, 2024

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
Talk app image
Files app and sidebars image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added 2. developing bug feature: signaling 📶 Internal and external signaling backends labels Dec 18, 2024
@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Dec 18, 2024
@Antreesy Antreesy self-assigned this Dec 18, 2024
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick comment, two things:

  • the warning basically will be shown in any non 2 person call in the future
  • we had this warning or a similar one in the past, can you check and find it or find where it got lost?

src/App.vue Outdated Show resolved Hide resolved
@Antreesy
Copy link
Contributor Author

we had this warning or a similar one in the past, can you check and find it or find where it got lost?

Never appeared after migration to Vue in 2019: 88d7d78

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue with the toast is that it gets clicked away and is not permanent enough. I would suggest to put a yellow NcNoteCard on the top of the right sidebar (or left navigation, although that seems to be less relevant if this only shows in a call) that shows throughout the duration of the call.

And it also needs to provide how to fix it – if shown to users, needs to say something actionable like "Contact your admin for further assistance"

@nickvergessen
Copy link
Member

If a sidebar it should be right, as left is folded away when starting a call.
Could also see an icon on the call view similarly to the connection warning?

src/App.vue Outdated Show resolved Hide resolved
@jancborchardt
Copy link
Member

@nickvergessen we could show that warning generally though, even when not in a call?

If only during a call is wanted, then yes best right sidebar.
And yeah we can use an icon in the call view, I'd even say use the same connection icon entry, just add another block of text in the popover?

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/14018/internal-signaling-warning branch from 2492498 to 0e10cbf Compare January 8, 2025 10:38
@Antreesy Antreesy marked this pull request as ready for review January 8, 2025 10:38
@Antreesy Antreesy changed the title fix(signaling): add UI warning in call with 4+ participants fix(signaling): add UI warning in call with 2+ participants Jan 8, 2025
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me.

We can also add it to the call view additionally as described by Jan, or we wait to see how the current version resonates.

@Antreesy Antreesy dismissed jancborchardt’s stale review January 8, 2025 12:36

Warning in the call view needs rework, addressed in another issue

@Antreesy Antreesy merged commit bb758e1 into main Jan 8, 2025
51 of 52 checks passed
@Antreesy Antreesy deleted the fix/14018/internal-signaling-warning branch January 8, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug feature: signaling 📶 Internal and external signaling backends
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants