feat: add 'Generate summary' integration: frontend ✨ #13803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceaf094 to
5a16319
Compare
DorraJaouad
approved these changes
Nov 22, 2024
src/stores/chatExtras.js
Outdated
Comment on lines
76
to
79
| getChatSummary: (state) => (token) => { | ||
| return Object.values(Object(state.chatSummary[token])).map(task => task.summary).join('\n\n') | ||
| ?? t('spreed', 'Empty summary response') | ||
| }, |
There was a problem hiding this comment.
This is where you should add the fallbacks (empty, error etc)
5a16319 to
4213c2f
Compare
DorraJaouad
reviewed
Nov 22, 2024
1 task
e2f3f7f to
b1f5b93
Compare
DorraJaouad
reviewed
Nov 22, 2024
|
|
||
| getChatSummaryTaskQueue: (state) => (token) => { | ||
| return Object.values(Object(state.chatSummary[token])) | ||
| }, |
There was a problem hiding this comment.
Suggested change
| }, | |
| }, | |
| hasTaskFailed: (state) => (token) => { | |
| return Object.values(Object(state.chatSummary[token])).any(task => task.status === TASK_PROCESSING.FAILED) | |
| }, |
Use this to show the hint that sthg went wrong in summarizing. If you think that there are many hints (along with AI disclaimer), then don't show the summary, stop any tasks after the failed ones and show the failed summary text.
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
b1f5b93 to
d5dac2b
Compare
|
/backport to stable30 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist