Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(calls): Add notifications for federated calls #12845

Merged
merged 5 commits into from
Jul 31, 2024
Merged

feat(calls): Add notifications for federated calls #12845

merged 5 commits into from
Jul 31, 2024

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jul 29, 2024 •
edited
Loading

☑️ Resolves

🛠️ API Checklist

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added 2. developing bug feature: api 🛠️ OCS API for conversations, chats and participants feature: call 📹 Voice and video calls feature: federation 🌐 labels Jul 29, 2024
@nickvergessen nickvergessen added this to the 💙 Next Beta (30) milestone Jul 29, 2024
@nickvergessen nickvergessen self-assigned this Jul 29, 2024
@nickvergessen nickvergessen mentioned this pull request Jul 30, 2024
Merged
3 tasks
@nickvergessen nickvergessen force-pushed the feat/12844/call-notifications branch from 43e0a3c to bb537f6 Compare July 30, 2024 22:46
@nickvergessen nickvergessen changed the title test: Add integration tests for call notifications feat(calls): Add notifications for federated calls Jul 30, 2024
@nickvergessen nickvergessen requested a review from danxuliu July 30, 2024 22:48
@nickvergessen
Copy link
Member Author

danxuliu and others added 4 commits July 31, 2024 13:37
@danxuliu @nickvergessen
test: Add integration tests for call notifications
0af497d 
[skip-ci]

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
@nickvergessen
fix(event): Make info available whether this request changed the acti…
432cf58 
…ve-since

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(federation): Add federated call notifications
099db18 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(calls): Also track the participant in_call locally to be able to …
413641d 
…handle notifications

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the feat/12844/call-notifications branch from bb537f6 to f85b5c9 Compare July 31, 2024 11:38
@nickvergessen nickvergessen enabled auto-merge July 31, 2024 11:39
@nickvergessen
fix(call): Fix integration test mix up of local and remote rooms
eb345e7 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the feat/12844/call-notifications branch from f85b5c9 to eb345e7 Compare July 31, 2024 11:40
@nickvergessen nickvergessen disabled auto-merge July 31, 2024 14:43
@nickvergessen nickvergessen merged commit 12d062f into main Jul 31, 2024
64 of 66 checks passed
@nickvergessen nickvergessen deleted the feat/12844/call-notifications branch July 31, 2024 14:43
@nickvergessen nickvergessen mentioned this pull request Aug 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees

@nickvergessen nickvergessen

Labels
3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: call 📹 Voice and video calls feature: federation 🌐
Projects
None yet
Milestone
v20.0.0-beta.2
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @Antreesy @danxuliu