Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bans): minor corrections #12739

Merged
merged 4 commits into from
Jul 16, 2024
Merged

fix(bans): minor corrections #12739

merged 4 commits into from
Jul 16, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jul 16, 2024 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏡 After
image
image
image

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • ⛑️ Tests are included or not possible

@Antreesy Antreesy added this to the 💙 Next Major (30) milestone Jul 16, 2024
@Antreesy Antreesy self-assigned this Jul 16, 2024
@DorraJaouad
Copy link
Contributor

Also do not close dialog when there is an error in banning or removing ? and to disable submit button on loading in order not to send multiple requests.

@Antreesy Antreesy force-pushed the fix/12293/ban-adjust branch 2 times, most recently from 26a717f to 918db2f Compare July 16, 2024 14:12
@Antreesy Antreesy requested a review from DorraJaouad July 16, 2024 17:06
DorraJaouad
DorraJaouad approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works :p

src/components/RightSidebar/Participants/Participant.vue Outdated Show resolved Hide resolved
Antreesy added 4 commits July 16, 2024 21:14
@Antreesy
fix(bans): wording adjustments
c777234 
- Adjust text in 403 view
- Sanitize ban information
- Use banned and moderator display names

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix(bans): handle server errors when deleting/banning
3a3e4a4 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix(bans): handle max length of internal note
f7c3c0e 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix(federation): allow to ban and set permissions to federated users
23f7378 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/12293/ban-adjust branch from eccdc03 to 23f7378 Compare July 16, 2024 19:21
@Antreesy Antreesy enabled auto-merge July 16, 2024 19:22
@Antreesy Antreesy merged commit 166da1c into main Jul 16, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/12293/ban-adjust branch July 16, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review bug feature: conversations 👥 feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
v20.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

Error on banning call still removes participant
3 participants
@Antreesy @DorraJaouad @nickvergessen