Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refactor messages list update in watchers #12658

Merged
merged 1 commit into from
Jul 16, 2024
Merged

fix: refactor messages list update in watchers #12658

merged 1 commit into from
Jul 16, 2024

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Jul 9, 2024 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad DorraJaouad force-pushed the fix/scroll-to-bottom branch from 2a40210 to 6bc0ef4 Compare July 12, 2024 11:26
@DorraJaouad DorraJaouad self-assigned this Jul 12, 2024
@DorraJaouad DorraJaouad requested a review from Antreesy July 12, 2024 11:29
@DorraJaouad DorraJaouad added feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client labels Jul 12, 2024
@DorraJaouad DorraJaouad added this to the 💙 Next Major (30) milestone Jul 12, 2024
@DorraJaouad DorraJaouad marked this pull request as ready for review July 12, 2024 11:30
Antreesy
Antreesy reviewed Jul 16, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest is good

src/components/ChatView.vue Outdated Show resolved Hide resolved
@DorraJaouad
fix: refactor messages list update in watchers and adjust boolean val…
ec546dd 
…ue updates for chat scrolled to bottom.

Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad force-pushed the fix/scroll-to-bottom branch from fb70a4a to ec546dd Compare July 16, 2024 13:09
@DorraJaouad DorraJaouad enabled auto-merge July 16, 2024 13:09
@DorraJaouad DorraJaouad merged commit 301a4eb into main Jul 16, 2024
46 checks passed
@DorraJaouad DorraJaouad deleted the fix/scroll-to-bottom branch July 16, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels
feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
v20.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
2 participants
@DorraJaouad @Antreesy