Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(federation): Handle federation configs when inviting instead of g… #11799

Merged
merged 1 commit into from
Mar 14, 2024
Merged

fix(federation): Handle federation configs when inviting instead of g… #11799

merged 1 commit into from
Mar 14, 2024

Conversation

nickvergessen
Copy link
Member

…eneric "Can not reach remote"

🛠️ API Checklist

Should allow for better error handling in the frontend in the future.
Returned error codes:

  • cloudId (is not well formed)
  • outgoing (outgoing shares are disabled)
  • federation (federation is disabled for the user)
  • trusted_servers (the cloud id is not from a trusted server but the restriction for it is enabled)

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added this to the 💞 Next Beta (29) milestone Mar 14, 2024
@nickvergessen nickvergessen self-assigned this Mar 14, 2024
@nickvergessen nickvergessen force-pushed the bugfix/noid/handle-federation-configs-on-invite branch from 4518eaa to 54bff7e Compare March 14, 2024 13:33
@nickvergessen
fix(federation): Handle federation configs when inviting instead of g…
e71ff6e 
…eneric "Can not reach remote"

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/handle-federation-configs-on-invite branch from 54bff7e to e71ff6e Compare March 14, 2024 13:42
@nickvergessen nickvergessen merged commit b197842 into main Mar 14, 2024
64 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/handle-federation-configs-on-invite branch March 14, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SystemKeeper SystemKeeper SystemKeeper approved these changes

@Antreesy Antreesy Awaiting requested review from Antreesy

Assignees

@nickvergessen nickvergessen

Labels
3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: conversations 👥 feature: federation 🌐
Projects
None yet
Milestone
v19.0.0-beta.2
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @SystemKeeper