Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(federation): Allow to federate setReadMarker() without lastReadMe… #11798

Merged
merged 2 commits into from
Mar 14, 2024
Merged

fix(federation): Allow to federate setReadMarker() without lastReadMe… #11798

merged 2 commits into from
Mar 14, 2024

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Mar 14, 2024 •
edited
Loading

…ssage ID

🛠️ API Checklist

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen
fix(federation): Allow to federate setReadMarker() without lastReadMe…
0df9631 
…ssage ID

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added 3. to review bug feature: chat 💬 Chat and system messages feature: api 🛠️ OCS API for conversations, chats and participants feature: federation 🌐 labels Mar 14, 2024
@nickvergessen nickvergessen added this to the 💞 Next Beta (29) milestone Mar 14, 2024
@nickvergessen nickvergessen requested a review from Antreesy March 14, 2024 10:43
@nickvergessen nickvergessen self-assigned this Mar 14, 2024
Antreesy
Antreesy approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@Antreesy Antreesy mentioned this pull request Mar 14, 2024
Merged
@nickvergessen
test(federation): Add integration tests for setting all kind of read …
afb65c1 
…markers

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen enabled auto-merge March 14, 2024 11:57
@nickvergessen nickvergessen merged commit b553b17 into main Mar 14, 2024
64 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/allow-to-federate-without-lastReadMessage branch March 14, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

Assignees

@nickvergessen nickvergessen

Labels
3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: chat 💬 Chat and system messages feature: federation 🌐
Projects
None yet
Milestone
v19.0.0-beta.2
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @Antreesy