Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(PresenterOverlay): make the overlay draggable. #11701

Merged
merged 2 commits into from
Mar 14, 2024
Merged

feat(PresenterOverlay): make the overlay draggable. #11701

merged 2 commits into from
Mar 14, 2024

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Mar 1, 2024 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

Overlay.1.mp4

🚧 Tasks

  • Code review
  • Design review

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad DorraJaouad self-assigned this Mar 1, 2024
@DorraJaouad DorraJaouad force-pushed the feat/noid/draggable-presenter-overlay branch from 2feb7d9 to 4df3265 Compare March 11, 2024 09:28
@DorraJaouad DorraJaouad requested a review from Antreesy March 11, 2024 09:46
@DorraJaouad DorraJaouad marked this pull request as ready for review March 11, 2024 09:46
@DorraJaouad DorraJaouad added this to the 💞 Next Beta (29) milestone Mar 11, 2024
Antreesy
Antreesy reviewed Mar 11, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise good, but I have doubts regarding visual part

cc @jancborchardt for design input

@DorraJaouad
chore(deps): install vue-draggable-resizable@v1
eee0695 
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad force-pushed the feat/noid/draggable-presenter-overlay branch from e57d6e7 to 6fcbc2a Compare March 13, 2024 11:30
Antreesy
Antreesy reviewed Mar 13, 2024
View reviewed changes
@DorraJaouad DorraJaouad force-pushed the feat/noid/draggable-presenter-overlay branch from 6fcbc2a to 645a006 Compare March 13, 2024 13:50
Antreesy
Antreesy approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from mentioned, good job! Don't forget to fix

@DorraJaouad
feat(PresenterOverlay): make the overlay draggable.
9e15ea3 
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad force-pushed the feat/noid/draggable-presenter-overlay branch from 645a006 to 9e15ea3 Compare March 13, 2024 19:13
@DorraJaouad DorraJaouad merged commit d206d55 into main Mar 14, 2024
46 checks passed
@DorraJaouad DorraJaouad deleted the feat/noid/draggable-presenter-overlay branch March 14, 2024 10:02
@DorraJaouad DorraJaouad mentioned this pull request Apr 16, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels
enhancement feature: call 📹 Voice and video calls
Projects
None yet
Milestone
v19.0.0-beta.2
Development

Successfully merging this pull request may close these issues.

Improvements to screensharing presenter overlay
2 participants
@DorraJaouad @Antreesy