fix(hosted-hpb): Correctly handle API response when the account expir… #10970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
commented
Nov 22, 2023
| // Account was deleted, so remove the information locally | ||
| $accountInfo = ['status' => 'deleted']; | ||
| } elseif ($e->getCode() === Http::STATUS_UNAUTHORIZED) { | ||
| // Account is expired and deletion is pending unless it's reactivated. |
There was a problem hiding this comment.
it seems previously expired accounts always received a 200 with body. Now it's a 401. Deleted accounts receive a 404.
So both cases are now specifically catched and handled so the status notifications happen as planned.
…ed or was deleted Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
5bae204 to
f40fc78
Compare
Antreesy
approved these changes
Nov 22, 2023
Signed-off-by: Joas Schilling <coding@schilljs.com>
|
/backport to stable27 |
|
/backport to stable26 |
This was referenced Nov 23, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ed or was deleted
☑️ Resolves
🛠️ API Checklist
🏁 Checklist
docs/has been updated or is not required