Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(settings): Allow requesting hosted HPB without being in "Can use … #10961

Merged
merged 1 commit into from
Nov 21, 2023
Merged

fix(settings): Allow requesting hosted HPB without being in "Can use … #10961

merged 1 commit into from
Nov 21, 2023

Conversation

nickvergessen
Copy link
Member

…Talk" group

☑️ Resolves

🛠️ API Checklist

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen
fix(settings): Allow requesting hosted HPB without being in "Can use …
08802d3 
…Talk" group

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the 💙 Next Beta (28) milestone Nov 21, 2023
@nickvergessen nickvergessen self-assigned this Nov 21, 2023
fancycode
fancycode approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@fancycode fancycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test, but code looks good and I can see your request on the server :-)

@nickvergessen nickvergessen merged commit fdac9c4 into main Nov 21, 2023
@nickvergessen nickvergessen deleted the bugfix/10002/allow-to-request-hosted-hpb-without-CanUseTalk branch November 21, 2023 14:15
@fancycode
Copy link
Member

Any chance for a backport? The customer that initially reported this is on 27, so would be great to have this in an update for them, too. Thanks!

@nickvergessen
Copy link
Member Author

/backport to stable27

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 21, 2023
Merged
@fancycode fancycode mentioned this pull request May 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fancycode fancycode fancycode approved these changes

Assignees

@nickvergessen nickvergessen

Labels
3. to review
Projects
None yet
Milestone
v18.0.0-rc.1
Development

Successfully merging this pull request may close these issues.

Error "Can not use Talk" when requesting HPB trial
2 participants
@nickvergessen @fancycode