Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chat): Adjust "author" when creating "Note to self" and "changelo… #10884

Merged
merged 2 commits into from
Nov 14, 2023
Merged

fix(chat): Adjust "author" when creating "Note to self" and "changelo… #10884

merged 2 commits into from
Nov 14, 2023

Conversation

nickvergessen
Copy link
Member

…g" conversations

☑️ Resolves

🛠️ API Checklist

Before After
grafik grafik
grafik grafik

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen
fix(chat): Adjust "author" when creating "Note to self" and "changelo…
0d15ee7 
…g" conversations

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added 3. to review feature: chat 💬 Chat and system messages feature: api 🛠️ OCS API for conversations, chats and participants labels Nov 13, 2023
@nickvergessen nickvergessen added this to the 💙 Next Beta (28) milestone Nov 13, 2023
@nickvergessen nickvergessen self-assigned this Nov 13, 2023
ChristophWurst
ChristophWurst reviewed Nov 14, 2023
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 on the change but I am not qualified to approve the code changes :D

@nickvergessen
feat(tests): Add integration test for note-to-self conversations
9b09df6 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/10875/adjust-author-of-notetoself-and-changelog-creation branch from d043b74 to 9b09df6 Compare November 14, 2023 13:32
@nickvergessen nickvergessen merged commit f4d3343 into main Nov 14, 2023
@nickvergessen nickvergessen deleted the bugfix/10875/adjust-author-of-notetoself-and-changelog-creation branch November 14, 2023 13:59
@nickvergessen nickvergessen mentioned this pull request Nov 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst left review comments

@SystemKeeper SystemKeeper SystemKeeper approved these changes

Assignees

@nickvergessen nickvergessen

Labels
3. to review feature: api 🛠️ OCS API for conversations, chats and participants feature: chat 💬 Chat and system messages
Projects
None yet
Milestone
v18.0.0-beta.3
Development

Successfully merging this pull request may close these issues.

System creates the *Note to self* room, not me
3 participants
@nickvergessen @ChristophWurst @SystemKeeper