Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

techdebt(context): Use injectFn instead of accessing IServerContainer #10782

Merged
merged 2 commits into from
Oct 26, 2023
Merged

techdebt(context): Use injectFn instead of accessing IServerContainer #10782

merged 2 commits into from
Oct 26, 2023

Conversation

nickvergessen
Copy link
Member

☑️ Resolves

🛠️ API Checklist

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen
techdebt(context): Use injectFn instead of accessing IServerContainer
df13939 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added 3. to review feature: api 🛠️ OCS API for conversations, chats and participants technical debt labels Oct 26, 2023
@nickvergessen nickvergessen added this to the 💙 Next Major (28) milestone Oct 26, 2023
@nickvergessen nickvergessen self-assigned this Oct 26, 2023
@nickvergessen
fix(CI): Satisfy psalm by clearing baseline
52878fb 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen merged commit b1294fb into master Oct 26, 2023
@nickvergessen nickvergessen deleted the techdebt/noid/use-injectFn-instead-of-accessing-iservercontainer branch October 26, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelklehr marcelklehr marcelklehr approved these changes

Assignees

@nickvergessen nickvergessen

Labels
3. to review feature: api 🛠️ OCS API for conversations, chats and participants technical debt
Projects
None yet
Milestone
v18.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @marcelklehr