Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NewMessageUploadEditor) - caption to file share #10730

Merged
merged 4 commits into from
Oct 23, 2023
Merged

feat(NewMessageUploadEditor) - caption to file share #10730

merged 4 commits into from
Oct 23, 2023

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Oct 18, 2023 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image Screenshot from 2023-10-18 17-22-50
image Screenshot from 2023-10-18 17-29-01

🚧 Tasks

🏁 Checklist

@Antreesy Antreesy added this to the 💙 Next Major (28) milestone Oct 18, 2023
@Antreesy Antreesy self-assigned this Oct 18, 2023
@Antreesy
render caption as part of the message
6b53b09 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
replace action buttons with NewMessage in upload editor
3615c73 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
upload shared files in parallel, pass caption to server with the last…
9fc9d06 
… file

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the feat/5354/captions-frontend branch from 5c377af to 9fc9d06 Compare October 19, 2023 08:07
@Antreesy
use local urls (blob) in file previews to not wait for server
892c22b 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy requested a review from DorraJaouad October 20, 2023 18:30
DorraJaouad
DorraJaouad approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 🦅.

Good to go.

@Antreesy Antreesy merged commit 701763e into master Oct 23, 2023
@Antreesy Antreesy deleted the feat/5354/captions-frontend branch October 23, 2023 13:11
@SystemKeeper SystemKeeper mentioned this pull request Nov 2, 2023
Closed
@ShGKme ShGKme mentioned this pull request May 7, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review enhancement feature: frontend 🖌️ "Web UI" client feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings
Projects
None yet
Milestone
v18.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

Frontend "File caption"
3 participants
@Antreesy @nickvergessen @DorraJaouad