-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add presenter overlay when sharing screen #10669
Conversation
0689a6c
to
64b51a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks cool code-wise and running! Nothing blocking from me.
Left some minor comments for improvements, and waiting for design team for decision
8e6c3e0
to
7dd9732
Compare
7dd9732
to
7093fee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some nitpick comments
7093fee
to
875ee0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool! :) @DorraJaouad only a very small adjustment: To make the hide icon more symmetric with the one to show the video, instead of the "eye" I'd propose account-off: https://pictogrammers.com/library/mdi/icon/account-off/
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
875ee0e
to
2692b84
Compare
So, good to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! :)
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🚧 Tasks
🏁 Checklist