feat(MediaSettings) start recording together with call #10637

Antreesy · 2023-10-05T12:07:09Z

🖌️ UI Checklist

From moderator perspective:

Before call start	During call (hidden)

🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
🖌️ Design was reviewed, approved or inspired by the design team
⛑️ Tests are included or not possible
📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

nickvergessen · 2023-10-05T13:34:20Z

Before call start (checked)

Will cause a jump in height of the dialog? If so I would skip showing the warning for the user toggling the checkbox

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>

DorraJaouad

Nothing is blocking code-wise.

Antreesy added 3. to review enhancement feature: frontend 🖌️ "Web UI" client feature: recordings ⏺️ Including the recording server labels Oct 5, 2023

Antreesy added this to the 💙 Next Major (28) milestone Oct 5, 2023

Antreesy requested review from nickvergessen and DorraJaouad October 5, 2023 12:07

Antreesy self-assigned this Oct 5, 2023

Antreesy force-pushed the feat/noid/start-recording-with-call branch from 7fcb33e to f03846a Compare October 6, 2023 10:29

Antreesy added 2 commits October 9, 2023 17:54

rename prop 'forceJoinCall' for readability

b4e01fd

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>

add option to start recording together with call for moderators

1383df0

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>

Antreesy force-pushed the feat/noid/start-recording-with-call branch from f03846a to 1383df0 Compare October 9, 2023 15:54

Antreesy requested a review from SystemKeeper October 9, 2023 16:06

DorraJaouad approved these changes Oct 10, 2023

View reviewed changes

Antreesy merged commit a9501cf into master Oct 12, 2023

Antreesy deleted the feat/noid/start-recording-with-call branch October 12, 2023 13:24