Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

techdebt(ParticipantsTab) - refactor participants list #10476

Merged
merged 3 commits into from
Sep 12, 2023

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Sep 8, 2023

☑️ Resolves

  • Preparations to apply RecycleScroller: Stop using image-avatars in huge rooms #5907 (comment)
  • Move out all logic from CurrentParticipants.vue and delete it:
    • Replace mixin userStatus with composable,
    • Move out complex method sortParticipants to composable (:warning: Not a clean move, some lines were modified. Please see thoroughly)
    • Move some computed properties and updateUserStatus method to the parent component
  • Follow-ups:

🖼️ Screenshots

No visual changes

🚧 Tasks

  • Code review
  • Manual testing

🏁 Checklist

src/composables/useUserStatus.js Outdated Show resolved Hide resolved
src/composables/useSortParticipants.js Outdated Show resolved Hide resolved
@Antreesy Antreesy requested a review from ShGKme September 12, 2023 14:10
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the techdebt/noid/refactor-participant-tab branch from c88d94e to 54e65df Compare September 12, 2023 16:29
@Antreesy
Copy link
Contributor Author

Squashed and rebased onto master, no changes

@Antreesy Antreesy enabled auto-merge September 12, 2023 16:30
@Antreesy
Copy link
Contributor Author

/backport to stable27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants