-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
techdebt(ParticipantsTab) - refactor participants list #10476
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DorraJaouad
reviewed
Sep 12, 2023
ShGKme
reviewed
Sep 12, 2023
ShGKme
approved these changes
Sep 12, 2023
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
c88d94e
to
54e65df
Compare
Squashed and rebased onto master, no changes |
/backport to stable27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
CurrentParticipants.vue
and delete it:userStatus
with composable,sortParticipants
to composable (:warning: Not a clean move, some lines were modified. Please see thoroughly)updateUserStatus
method to the parent component<ParticipantsList />
or it's copy to RecycleSroller<LoadingParticipant />
with<LoadingPlaceholder />
techdebt(LoadingPlaceholder) - rewrite skeleton component #10489🖼️ Screenshots
No visual changes
🚧 Tasks
🏁 Checklist
docs/
has been updated or is not required