Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(CallView) - add an option to disable background blur in call #10464

Merged
merged 1 commit into from
Sep 6, 2023
Merged

perf(CallView) - add an option to disable background blur in call #10464

merged 1 commit into from
Sep 6, 2023

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Sep 4, 2023 •
edited
Loading

☑️ Resolves

🖼️ Screenshots

Menu (enabled by default, reset on logout, same as all information in BrowserStorage):
image

💻 Screen 🏚️ Before (Enabled) 🏡 After (Disabled)
3840 x 2160 pixels (4K) image image
1920 x 1080 pixels (Full HD) image image

🚧 Tasks

🏁 Checklist

@Antreesy
add performance section with background blur option to the Talk settings
d43d1d7 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added this to the 💙 Next Major (28) milestone Sep 4, 2023
@Antreesy Antreesy self-assigned this Sep 4, 2023
@Antreesy Antreesy changed the title add performance section with background blur option to the Talk settings perf(CallView) - add an option to disable background blur in call Sep 4, 2023
danxuliu
danxuliu approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@Antreesy
Copy link
Contributor Author

Antreesy commented Sep 6, 2023

/backport to stable27

@Antreesy Antreesy merged commit def55fe into master Sep 6, 2023
@Antreesy Antreesy deleted the fix/7896/disable-background-blur branch September 6, 2023 07:54
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 6, 2023
Merged
@Antreesy
Copy link
Contributor Author

Antreesy commented Sep 6, 2023

/backport to stable26

@Antreesy
Copy link
Contributor Author

Antreesy commented Sep 6, 2023 •
edited
Loading

/backport to stable25

@Antreesy Antreesy mentioned this pull request Sep 6, 2023
Merged
1 task
@nextcloud nextcloud deleted a comment from backportbot-nextcloud bot Sep 6, 2023
@Antreesy Antreesy mentioned this pull request Sep 6, 2023
Merged
1 task
@nextcloud nextcloud deleted a comment from backportbot-nextcloud bot Sep 6, 2023
@marcoambrosini
Copy link
Member

@nextcloud/designers I think we should just go back to a solid background here. It really doesn't make sense to have a setting for this.

@SystemKeeper SystemKeeper mentioned this pull request Nov 25, 2023
Open
@Antreesy Antreesy mentioned this pull request Jul 3, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danxuliu danxuliu danxuliu approved these changes

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees

@Antreesy Antreesy

Labels
3. to review feature: call 📹 Voice and video calls feature: frontend 🖌️ "Web UI" client performance 🚀
Projects
None yet
Milestone
v18.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
4 participants
@Antreesy @marcoambrosini @danxuliu @nickvergessen