Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to border in focus #10445

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Change to border in focus #10445

merged 1 commit into from
Sep 4, 2023

Conversation

DorraJaouad
Copy link
Contributor

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🚧 Tasks

  • visual review
  • code review

@DorraJaouad DorraJaouad added this to the 💘 Last RC (27) milestone Sep 1, 2023
@DorraJaouad DorraJaouad requested a review from ShGKme September 1, 2023 11:33
@DorraJaouad DorraJaouad self-assigned this Sep 1, 2023
@DorraJaouad
Copy link
Contributor Author

/backport to stable27

ShGKme
ShGKme requested changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving styles to Conversation.vue breaks some items, because, unfortunately, we use just NcListItem sometimes.

Either all styles should be kept in LeftSidebar or all NcListItems should be replace with Conversation.vue.

bug

src/components/LeftSidebar/ConversationsList/Conversation.vue Outdated Show resolved Hide resolved
@DorraJaouad
Change to border in focus
10527f0 
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad force-pushed the fix/10443/change-outline-to-border branch from d902f39 to 10527f0 Compare September 1, 2023 18:16
@DorraJaouad DorraJaouad merged commit 18d875e into master Sep 4, 2023
@DorraJaouad DorraJaouad deleted the fix/10443/change-outline-to-border branch September 4, 2023 09:41
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 4, 2023
Merged
@Antreesy Antreesy mentioned this pull request Sep 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels
3. to review bug feature: conversations 👥 feature: frontend 🖌️ "Web UI" client regression
Projects
None yet
Milestone
v17.1.0
Development

Successfully merging this pull request may close these issues.

Conversation item border is cut of when tabbing
2 participants
@DorraJaouad @ShGKme