Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bot)!: Ensure bot uniqueness #10368

Merged
merged 4 commits into from
Aug 25, 2023

Conversation

nickvergessen
Copy link
Member

🚧 Tasks

  • Allow uninstalling via Event
  • Allow uninstalling based on URL
  • Ensure a bot is only once in a room
  • Ensure a bot is only once on a server
  • Ensure a bot is uniquely identified by it's secret

🏁 Checklist

@nickvergessen nickvergessen added 3. to review feature: api 🛠️ OCS API for conversations, chats and participants feature: bots 🤖 /commands in chat messages labels Aug 25, 2023
@nickvergessen nickvergessen added this to the 💙 Next Major (28) milestone Aug 25, 2023
@nickvergessen nickvergessen requested a review from bigcat88 August 25, 2023 10:39
@nickvergessen nickvergessen self-assigned this Aug 25, 2023
@nickvergessen
Copy link
Member Author

/backport to stable27

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
…escriptions of options

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/ensure-bot-uniqueness branch from 9747456 to 335f7d6 Compare August 25, 2023 11:09
@nickvergessen nickvergessen merged commit 2161f97 into master Aug 25, 2023
@nickvergessen nickvergessen deleted the bugfix/noid/ensure-bot-uniqueness branch August 25, 2023 12:28
@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review feature: api 🛠️ OCS API for conversations, chats and participants feature: bots 🤖 /commands in chat messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants