Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Message) - copy formatted message (with markdown and mentions) to clipboard #10322

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Aug 23, 2023

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
Screenshot from 2023-08-24 09-54-59 Screenshot from 2023-08-24 09-54-11

In action:

copy-raw.webm

🚧 Tasks

  • Visual check
  • Code review

🏁 Checklist

@Antreesy Antreesy added this to the 💙 Next Major (28) milestone Aug 23, 2023
@Antreesy Antreesy self-assigned this Aug 23, 2023
@Antreesy
Copy link
Contributor Author

/backport to stable27

Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @Antreesy, I have a couple of points:

  • could we use content-copy icon?
  • could we move both copy actions below every other action, just above delete?

@Antreesy
Copy link
Contributor Author

Antreesy commented Aug 23, 2023

  • could we use content-copy icon?

Did already, forgot to update screenshot

  • could we move both copy actions below every other action, just above delete?

If you think that would be better, sure, but with separator
We have also unread, forward, translate, and unknown amount of integrations buttons

@marcoambrosini
Copy link
Member

unknown amount of integrations buttons

Could we put those in a submenu maybe?

@nickvergessen
Copy link
Member

Could we put those in a submenu maybe?

Maybe not in RC stage but can do it later on.

Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Time to fixup

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the feat/10288/copy-raw-message branch from 826eb97 to 88e56ac Compare August 24, 2023 07:58
@Antreesy Antreesy changed the title add an action button to copy message text to clipboard feat(Message) - copy formatted message (with markdown and mentions) to clipboard Aug 24, 2023
@Antreesy Antreesy enabled auto-merge August 24, 2023 07:59
@Antreesy Antreesy merged commit 55c8a4a into master Aug 24, 2023
@Antreesy Antreesy deleted the feat/10288/copy-raw-message branch August 24, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Ability to copy message text (raw) to Clipboard
3 participants