Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Message) - refactor components and store #10260

Merged
merged 3 commits into from
Aug 18, 2023

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

  • Reduce amount of props used / passed to the often appeared components
  • Reduce amount of component re-renders (:construction: still a lot of work to do)

🖼️ Screenshots

🏚️ Before 🏡 After
Screenshot from 2023-08-18 00-13-11 Screenshot from 2023-08-18 00-13-22
--- displayName of author has 4px bigger distance from the first message

🚧 Tasks

  • Visual check
  • Manual check
  • Code review

🏁 Checklist

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added this to the 💙 Next Major (28) milestone Aug 17, 2023
@Antreesy Antreesy requested a review from DorraJaouad August 17, 2023 22:21
@Antreesy Antreesy self-assigned this Aug 17, 2023
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code reviewed ✅
and tested. ✅

@Antreesy Antreesy merged commit 75f5bb7 into master Aug 18, 2023
@Antreesy Antreesy deleted the fix/noid/simplify-message-component branch August 18, 2023 10:50
@Antreesy
Copy link
Contributor Author

/backport to stable27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants