-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(MediaSettings) - Adjust the preview background update to only change in video when confirmed #10188
feat(MediaSettings) - Adjust the preview background update to only change in video when confirmed #10188
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work, nothing blocking - just remarks about wording / naming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @DorraJaouad & @Antreesy :)
I think "Apply settings" works well for every setting there, and we should use it it in the devices page too. By that I mean that both camera and microphone device settings shouldn't immediately affect the streams in the call but only the preview videos and mic level.
Changes should occur only when "apply settings" button is clicked.
What do you think?
Should be possible to split this logic to preview and apllied device, same as for background, so I'd like to see it |
…firmed Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
83732ca
to
febde91
Compare
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
/backport to stable27 |
☑️ Resolves
🚧 Tasks
🏁 Checklist
docs/
has been updated or is not required