Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable27] feat(store) replace Vuex settingsStore with equivalent Pinia store #10100

Merged
merged 2 commits into from
Aug 4, 2023
Merged

[stable27] feat(store) replace Vuex settingsStore with equivalent Pinia store #10100

merged 2 commits into from
Aug 4, 2023

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Aug 3, 2023

Manual backport of #9892
Backported as needed for #10059

Tested on web client

Antreesy added 2 commits August 3, 2023 13:51
@Antreesy
install and initialize pinia
9d40182 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>

(cherry picked from commit dab51e4)
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
replace Vuex settingsStore.js to Pinia settings.js
159ed26 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
(cherry picked from commit ec5dd42)
@Antreesy Antreesy added enhancement feature: frontend 🖌️ "Web UI" client dependencies Pull requests that update a dependency file labels Aug 3, 2023
@Antreesy Antreesy added this to the 💘 Next Minor-Beta (27) milestone Aug 3, 2023
@Antreesy Antreesy self-assigned this Aug 3, 2023
nickvergessen
nickvergessen approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@nickvergessen nickvergessen merged commit 9840298 into stable27 Aug 4, 2023
@nickvergessen nickvergessen deleted the backport/9892/stable27 branch August 4, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Antreesy Antreesy

Labels
dependencies Pull requests that update a dependency file enhancement feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
v17.1.0-rc.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Antreesy @nickvergessen