Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(MessagesList) - history mode for old messages #10084

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

feat(MessagesList) - history mode for old messages #10084

wants to merge 6 commits into from
+206 −49

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jul 30, 2023 •
edited
Loading

☑️ Resolves

🖼️ Screenshots

2025-01-22_14h35_25.mp4

🚧 Tasks

  • Known issues:
    • Switching between modes purges the messages list, whatever is fetched there
    • Search in call
    • Call start while in 'history' mode
  • Manual testing
  • Design review
  • Code review

🏁 Checklist

@Antreesy Antreesy added this to the 💜 Next Major (28) milestone Jul 30, 2023
@Antreesy Antreesy self-assigned this Jul 30, 2023
@Antreesy Antreesy requested review from ShGKme and nickvergessen July 30, 2023 14:51
@Antreesy Antreesy force-pushed the fix/6046/block-message-polling branch from f9e00b5 to fe05739 Compare August 27, 2023 18:10
@Antreesy Antreesy force-pushed the fix/6046/block-message-polling branch from fe05739 to a948146 Compare March 1, 2024 18:26
@Antreesy Antreesy changed the base branch from main to fix/noid/message-old-update March 1, 2024 18:34
@Antreesy Antreesy force-pushed the fix/noid/message-old-update branch from 8a9dcfe to 30fd214 Compare March 1, 2024 22:56
@Antreesy Antreesy force-pushed the fix/6046/block-message-polling branch from a948146 to fdf6721 Compare March 1, 2024 23:10
Base automatically changed from fix/noid/message-old-update to main March 2, 2024 09:14
@Antreesy Antreesy mentioned this pull request Apr 19, 2024
Merged
9 tasks
@danxuliu danxuliu removed this from the v20.0.0-beta.1 milestone Jul 26, 2024
@danxuliu danxuliu added this to the 💙 Next Beta (30) milestone Jul 26, 2024
@Antreesy Antreesy force-pushed the fix/6046/block-message-polling branch 2 times, most recently from 528c8d8 to 92972aa Compare January 22, 2025 13:09
@Antreesy Antreesy requested a review from DorraJaouad January 22, 2025 13:32
@Antreesy Antreesy marked this pull request as ready for review January 22, 2025 13:34
@Antreesy Antreesy marked this pull request as draft January 22, 2025 15:56
@Antreesy
fix(messagesStore): ease messages list around last read message
47e96bd 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix(MessagesList): rename method to pollNewMessages
ffaa755 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix(messagesStore): allow to fetch messages in both directions
d3b9886 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix(MessagesList): disable long polling by default
aa62a34 
- only start when chat end is reached

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix(MessagesList): reinitialize chat if focused messages is out of range
832b73d 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
[wip]
e178a9d 
[skip ci]

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/6046/block-message-polling branch from 92972aa to e178a9d Compare January 23, 2025 17:48
@Antreesy Antreesy changed the base branch from main to fix/noid/ease-message-list January 23, 2025 17:48
@Antreesy Antreesy force-pushed the fix/noid/ease-message-list branch from 47e96bd to 628071d Compare January 24, 2025 14:15
Base automatically changed from fix/noid/ease-message-list to main January 27, 2025 12:21
@Antreesy Antreesy mentioned this pull request Feb 14, 2025
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme Awaiting requested review from ShGKme

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

At least 1 approving review is required to merge this pull request.

Assignees

@Antreesy Antreesy

Labels
2. developing enhancement feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
🪺 Next Major (32)
3 participants
@Antreesy @nickvergessen @danxuliu