Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gitignore): ignore JetBrains IDEs settings #10017

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jul 19, 2023

☑️ Resolves

We don't share any IDE settings in the repository, while we ignore only Microsoft Visual Studio Code settings.

This PR propose to ignore also JetBrains IDEs (such as PhpStorm) and JetBrains Fleet (new VSCode like IDE from JetBrains).

🏁 Checklist

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
Copy link
Contributor Author

ShGKme commented Jul 19, 2023

Some generators make more complex gitignore, but it seems, it's fine to just ignore an entire directory

https://www.toptal.com/developers/gitignore/api/jetbrains+all

@ShGKme
Copy link
Contributor Author

ShGKme commented Jul 19, 2023

@nickvergessen Would you mind backport it to stable27..25?

It was always annoying to me :D

@ShGKme ShGKme enabled auto-merge July 19, 2023 13:27
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally, someone made this brave move 🦭
I'm personally for backporting, shouldn't touch anything code-related

@ShGKme ShGKme merged commit 2dac5b0 into master Jul 19, 2023
@ShGKme ShGKme deleted the chore/gitignore-IDE-files branch July 19, 2023 14:31
@ShGKme
Copy link
Contributor Author

ShGKme commented Jul 19, 2023

/backport to stable27

@ShGKme
Copy link
Contributor Author

ShGKme commented Jul 19, 2023

/backport to stable26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants