Generate a PIN when inviting an email address

Signed-off-by: Joas Schilling <coding@schilljs.com>

lib/Controller/RoomController.php

@@ -1190,7 +1190,9 @@ public function addParticipantToRoom(string $newParticipant, string $source = 'u
 				$data = ['type' => $this->room->getType()];
 			}
 
-			$this->guestManager->inviteByEmail($this->room, $newParticipant);
+			$participant = $this->participantService->inviteEmailAddress($this->room, $newParticipant);
+
+			$this->guestManager->sendEmailInvitation($this->room, $participant);
 
 			return new DataResponse($data);
 		} else {

lib/GuestManager.php

@@ -167,7 +167,10 @@ public function getNamesBySessionHashes(array $sessionHashes): array {
 		return $map;
 	}
 
-	public function inviteByEmail(Room $room, string $email): void {
+	public function sendEmailInvitation(Room $room, Participant $participant): void {
+		$email = $participant->getAttendee()->getActorId();
+		$pin = $participant->getAttendee()->getPin();
+
 		$event = new AddEmailEvent($room, $email);
 		$this->dispatcher->dispatch(self::EVENT_BEFORE_EMAIL_INVITE, $event);
 
@@ -182,6 +185,8 @@ public function inviteByEmail(Room $room, string $email): void {
 			'invitee' => $invitee,
 			'roomName' => $room->getDisplayName(''),
 			'roomLink' => $link,
+			'email' => $email,
+			'pin' => $pin,
 		]);
 
 		if ($user instanceof IUser) {
@@ -200,6 +205,11 @@ public function inviteByEmail(Room $room, string $email): void {
 			$subject
 		);
 
+		if ($pin) {
+			// FIXME wrap in text
+			$template->addBodyText($pin);
+		}
+
 		$template->addBodyButton(
 			$this->l->t('Join »%s«', [$room->getDisplayName('')]),
 			$link

lib/Service/ParticipantService.php

@@ -23,6 +23,7 @@
 
 namespace OCA\Talk\Service;
 
+use OCA\Talk\Events\AddEmailEvent;
 use OCA\Talk\Events\AddParticipantsEvent;
 use OCA\Talk\Events\JoinRoomGuestEvent;
 use OCA\Talk\Events\JoinRoomUserEvent;
@@ -34,6 +35,7 @@
 use OCA\Talk\Exceptions\InvalidPasswordException;
 use OCA\Talk\Exceptions\ParticipantNotFoundException;
 use OCA\Talk\Exceptions\UnauthorizedException;
+use OCA\Talk\GuestManager;
 use OCA\Talk\Model\Attendee;
 use OCA\Talk\Model\AttendeeMapper;
 use OCA\Talk\Model\Session;
@@ -49,6 +51,7 @@
 use OCP\IUser;
 use OCP\IUserManager;
 use OCP\Security\ISecureRandom;
+use OCP\Util;
 
 class ParticipantService {
 	/** @var AttendeeMapper */
@@ -83,6 +86,7 @@ public function __construct(AttendeeMapper $attendeeMapper,
 		$this->connection = $connection;
 		$this->dispatcher = $dispatcher;
 		$this->userManager = $userManager;
+		$this->userManager = $userManager;
 		$this->timeFactory = $timeFactory;
 	}
 
@@ -213,6 +217,33 @@ public function addUsers(Room $room, array $participants): void {
 		$this->dispatcher->dispatch(Room::EVENT_AFTER_USERS_ADD, $event);
 	}
 
+	/**
+	 * @param Room $room
+	 * @param string $email
+	 * @return Participant
+	 */
+	public function inviteEmailAddress(Room $room, string $email): Participant {
+		$lastMessage = 0;
+		if ($room->getLastMessage() instanceof IComment) {
+			$lastMessage = (int) $room->getLastMessage()->getId();
+		}
+
+		$attendee = new Attendee();
+		$attendee->setRoomId($room->getId());
+		$attendee->setActorType('emails');
+		$attendee->setActorId($email);
+
+		// FIXME Only do this when SIP is enabled?
+		$attendee->setPin($this->generatePin());
+
+		$attendee->setParticipantType(Participant::GUEST);
+		$attendee->setLastReadMessage($lastMessage);
+		$this->attendeeMapper->insert($attendee);
+		// FIXME handle duplicate invites gracefully
+
+		return new Participant($room, $attendee, null);
+	}
+
 	public function ensureOneToOneRoomIsFilled(Room $room): void {
 		if ($room->getType() !== Room::ONE_TO_ONE_CALL) {
 			return;
@@ -603,4 +634,20 @@ public function hasActiveSessionsInCall(Room $room): bool {
 
 		return (bool) $row;
 	}
+
+	protected function generatePin(int $entropy = 7): string {
+		$pin = '';
+		// Do not allow to start with a '0' as that is a special mode on the phone server
+		// Also there are issues with some providers when you enter the same number twice
+		// consecutive too fast, so we avoid this as well.
+		$lastDigit = '0';
+		for ($i = 0; $i < $entropy; $i++) {
+			$lastDigit = $this->secureRandom->generate(1,
+				str_replace($lastDigit, '', ISecureRandom::CHAR_DIGITS)
+			);
+			$pin .= $lastDigit;
+		}
+
+		return $pin;
+	}
 }