User is not found when is searched by name and one of surnames #7510

[fgsl]

Fixes #7510

[MorrisJobke]

cc @nextcloud/ldap

[MorrisJobke]

Copying my comment from #7510:

I would still like to have this properly documented instead of adding another hidden feature that adds more code. You could simply search for "*eyer" to find "Meyer" aswell as "Beyer" in the search field.

[blizzz]

should not be a system value, but applications specific. And per configuration. Add it to OCA\User_LDAP\Configuration and you can read it from $this->connection in the Access class.

[fgsl]

Ok, @blizzz, I will change and submit again.

[blizzz]

I would still like to have this properly documented instead of adding another hidden feature that adds more code. You could simply search for "*eyer" to find "Meyer" aswell as "Beyer" in the search field.

I am not vetoing this… I'd be OK but not super happy either. @fgsl convince us?

[fgsl]

Hi, @blizzz. Sorry, but I feel that awareness of Access::escapeFilterPart() would make all more complicated. After read your post, I thought about it, but, if I really understand, we can fall in something like (not good) idea below:

1. Create two static attributes for Access class:

private static $escapeFilterPartSearch = null;
private static $escapeFilterPartReplace = null;

2. Create two static methods for Access class:

private static function getEscapeFilterPartSearch(){
    if (null == self::$escapeFilterPartSearch){
        self::$escapeFilterPartSearch = ($this->connection->ldapMedialSearch, array('\\', '(', ')'), array('*', '\\', '(', ')'));
    }
    return self::$escapeFilterPartSearch;
}
private static function getEscapeFilterPartReplace(){
    if (null == self::$escapeFilterPartReplace){
        self::$escapeFilterPartReplace = ($this->connection->ldapMedialSearch, array('\\\\', '\\(', '\\)'), array('\\\\', '\\(', '\\)'),);
    }
    return self::$escapeFilterPartReplace;
}

3. Change three last lines of Access::escapeFilterPart() for this:

return $asterisk . str_replace(self::getEscapeFilterPartSearch(), self::getEscapeFilterPartReplace(), $input);

[MorrisJobke]

@fgsl You merged master into your branch ... maybe a git rebase onto of current master is a lot better to keep the PR clean. See http://morrisjobke.de/2015/12/03/How-to-do-a-git-rebase/ for some steps to do so, otherwise reach out here so we could guide you :)

[fgsl]

@fgsl You merged master into your branch ... maybe a git rebase onto of current master is a lot better to keep the PR clean. See http://morrisjobke.de/2015/12/03/How-to-do-a-git-rebase/ for some steps to do so, otherwise reach out here so we could guide you :)

Thank you and I'm sorry, @MorrisJobke. I will follow guidelines.

[fgsl]

@MorrisJobke and @blizzz , I made a mistake and had to submit a new pull request: #8760.

[MorrisJobke]

@MorrisJobke and @blizzz , I made a mistake and had to submit a new pull request: #8760.

Don't worry :)