-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move /cloud/capabilities and /cloud/user to Core #777
Conversation
@rullzer, thanks for your PR! By analyzing the annotation information on this pull request, we identified @DeepDiver1975, @tomneedham and @nickvergessen to be potential reviewers |
]; | ||
return new DataResponse(['data' => $data]); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
ad3a0ae
to
a5814a0
Compare
a5814a0
to
e2f5455
Compare
#691 is in. CC: @MorrisJobke @LukasReschke @BernhardPosselt @icewind1991 @nickvergessen |
👍 |
Tested and the API works as before 👍 |
Move /cloud/capabilities and /cloud/user to Core
Requirese #691
My ongoing quest.
Basically move
/cloud/capabilities
and/cloud/user
to the Core app. Which means we can use the AppFramework and get rid of deprecated API calls.Lets see what CI says here.