Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update icewind/smb to 2.0.3 #7165

Merged
merged 1 commit into from
Nov 14, 2017
Merged

update icewind/smb to 2.0.3 #7165

merged 1 commit into from
Nov 14, 2017

Conversation

icewind1991
Copy link
Member

  • Fix compatibility issue with newer versions of smbclient
  • Fix smb2/smb3 path encoding issue
  • Throw proper error messages on smb version mismatch

@icewind1991
update icewind/smb to 2.0.3
418e49d 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Nov 14, 2017
@icewind1991 icewind1991 added this to the Nextcloud 13 milestone Nov 14, 2017
nickvergessen
nickvergessen approved these changes Nov 14, 2017
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it should be fine,
could find anything obvious

@MorrisJobke MorrisJobke merged commit a3f86b9 into master Nov 14, 2017
@MorrisJobke MorrisJobke deleted the smb-2.0.3 branch November 14, 2017 16:46
@icewind1991 icewind1991 mentioned this pull request Jan 10, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@LukasReschke LukasReschke Awaiting requested review from LukasReschke

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 13
Development

Successfully merging this pull request may close these issues.
3 participants
@icewind1991 @nickvergessen @MorrisJobke