-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change CALDAV to allow calendars be shared with circles. #6512
Change CALDAV to allow calendars be shared with circles. #6512
Conversation
@viniciuscb, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975, @nickvergessen and @georgehrke to be potential reviewers. |
See #5638 |
Thanks for the link @tcitworld :) @viniciuscb Unfortunately, my current work does not take full profit of Circles, as it is only working locally and not using the federated link; meaning you can't share to a remote nextcloud. If you want to dive into that work, we should arrange a talk somewhere (IRC, telegram, keybase) |
Hi @daita my implementation also does not take care of federated circles :-( Your implementation in #5638 is more complete. We didn't have to change caldav to create a share, only to display a share. Modifications in the calendar app (javascript) were enough to create a 'share to circle' in calendar. |
I will work on a calendar federated share 'later'. This works fine for local share. |
@daita please inform me if you need some help before the feature freeze on friday. |
Moved to 14. |
@daita Please have a look at this |
Hey @daita, @viniciuscb, is this feature definitely coming in Nextcloud 14 or should we expect it earlier? Thank you very much for your contribution, guys! Yours |
@danxuliu @daita @georgehrke What about this one? It's laying around for quite long already :/ |
let's close this, |
Why close this? Shouldn't we implement this feature? Even if it's only for Nextcloud 15? |
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
This works with nextcloud/circles#260 Signed-off-by: Vinicius Cubas Brand <viniciuscb@gmail.com>
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
This is good to get in imho: to test:
|
This comment has been minimized.
This comment has been minimized.
Let me fix the phan failures here. |
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Let me also fix the dependency injection for the app manager into the |
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works 👍
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
I fixed them in the latest commit. Let's see what CI says. |
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
We've developed a change in the CALENDAR app to allow sharing calendars with circles.
This proposed modification allows that a user can see calendars shared with circles that s/he belongs to.
The modifications in CALENDAR are in the pr:
nextcloud/calendar#602