Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CALDAV to allow calendars be shared with circles. #6512

Merged

Conversation

viniciuscb
Copy link
Member

@viniciuscb viniciuscb commented Sep 14, 2017

We've developed a change in the CALENDAR app to allow sharing calendars with circles.

This proposed modification allows that a user can see calendars shared with circles that s/he belongs to.

The modifications in CALENDAR are in the pr:
nextcloud/calendar#602

@mention-bot
Copy link

@viniciuscb, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975, @nickvergessen and @georgehrke to be potential reviewers.

@MariusBluem
Copy link
Member

@daita

@tcitworld
Copy link
Member

See #5638

@ArtificialOwl
Copy link
Member

Thanks for the link @tcitworld :)

@viniciuscb Unfortunately, my current work does not take full profit of Circles, as it is only working locally and not using the federated link; meaning you can't share to a remote nextcloud.

If you want to dive into that work, we should arrange a talk somewhere (IRC, telegram, keybase)

@viniciuscb
Copy link
Member Author

Hi @daita my implementation also does not take care of federated circles :-(
We will not use federated circles, at least not at this moment. Is only this that is needed to your PR to enter in master?

Your implementation in #5638 is more complete. We didn't have to change caldav to create a share, only to display a share. Modifications in the calendar app (javascript) were enough to create a 'share to circle' in calendar.

@viniciuscb
Copy link
Member Author

@dtygel

@ArtificialOwl ArtificialOwl added this to the Nextcloud 13 milestone Oct 18, 2017
@ArtificialOwl
Copy link
Member

I will work on a calendar federated share 'later'. This works fine for local share.

@viniciuscb
Copy link
Member Author

@daita please inform me if you need some help before the feature freeze on friday.

@MorrisJobke MorrisJobke modified the milestones: Nextcloud 13, Nextcloud 14 Dec 8, 2017
@MorrisJobke
Copy link
Member

Moved to 14.

@MorrisJobke MorrisJobke added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Mar 6, 2018
@MorrisJobke
Copy link
Member

@daita Please have a look at this

@GoetheG
Copy link

GoetheG commented May 19, 2018

Hey @daita, @viniciuscb,

is this feature definitely coming in Nextcloud 14 or should we expect it earlier?

Thank you very much for your contribution, guys!

Yours

@MorrisJobke MorrisJobke added the stale Ticket or PR with no recent activity label Jun 19, 2018
@MorrisJobke
Copy link
Member

@danxuliu @daita @georgehrke What about this one? It's laying around for quite long already :/

@nextcloud-bot nextcloud-bot removed the stale Ticket or PR with no recent activity label Jun 29, 2018
@ArtificialOwl
Copy link
Member

let's close this,

@MorrisJobke MorrisJobke removed this from the Nextcloud 15 milestone Jun 29, 2018
@georgehrke
Copy link
Member

Why close this?

Shouldn't we implement this feature? Even if it's only for Nextcloud 15?

Signed-off-by: Georg Ehrke <developer@georgehrke.com>
viniciuscb and others added 3 commits March 1, 2019 17:04
This works with nextcloud/circles#260

Signed-off-by: Vinicius Cubas Brand <viniciuscb@gmail.com>
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke
Copy link
Member

This is good to get in imho:

to test:

  • just create a circle.
  • for now, check the circle_id in oc_circles_members
  • share it:
    curl 'http://nextcloud.local/remote.php/dav/calendars/admin/new-calendar/' -u admin:admin -H 'Content-Type: application/xml; charset=UTF-8' -H 'Accept: */*' -H 'Depth: 0' --data-binary '<x3:share xmlns:x3="http://owncloud.org/ns"><x3:set><x0:href xmlns:x0="DAV:">principal:principals/circles/*circleId*</x0:href></x3:set></x3:share>' --compressed
  • make sure it shows up as a calendar for members of the circle.

@MorrisJobke MorrisJobke mentioned this pull request Mar 4, 2019
45 tasks
@MorrisJobke

This comment has been minimized.

@MorrisJobke
Copy link
Member

Let me fix the phan failures here.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke
Copy link
Member

Let me also fix the dependency injection for the app manager into the Principal. Then I will review this one here.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 5, 2019
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke mentioned this pull request Mar 6, 2019
9 tasks
@MorrisJobke

This comment has been minimized.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke
Copy link
Member

CI fails 🙈

I fixed them in the latest commit. Let's see what CI says.

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 12, 2019
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke merged commit f0c85a0 into nextcloud:master Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants