Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable30] fix: don't use cached root info from shared cache if the watcher has detected an update #50761

Open
wants to merge 2 commits into
base: stable30
Choose a base branch
from

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Feb 11, 2025

Backport of #50324

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added the 3. to review Waiting for reviews label Feb 11, 2025
@backportbot backportbot bot added this to the Nextcloud 30.0.6 milestone Feb 11, 2025
Signed-off-by: Robin Appelman <robin@icewind.nl>
…detected an update

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
Copy link
Member

removed the interface changes

$this->watcher = parent::getWatcher($path, $storage);
if ($cache instanceof Cache && $this->watcher instanceof Watcher) {

Check notice

Code scanning / Psalm

RedundantConditionGivenDocblockType Note

Docblock-defined type OC\Files\Cache\Watcher for $this->watcher is always OC\Files\Cache\Watcher
This was referenced Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants