-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sharing): Allow to set default view mode for public shares #50739
Conversation
/backport to stable31 |
1f4a776
to
135965e
Compare
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM code and function.
However it feels off to have view controls in the share settings (I am aware this was there before) but maybe the toggle/checkbox can be moved out and displayed on the actual file list controls.
cc: @marcoambrosini
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar concern as Fon regarding the cost/benefice of this feature. Where the cost is having yet another config option.
I agree with the concern raised @susnux |
Yes it only makes sense for images / videos. I would say thats not the majority of Nextcloud use cases.
Well its just a checkbox, nothing new in the backend. I think we have both use cases of sharing images and sharing documents / files. Haven an option here allows users to decide which one is the best based on their use case instead of some use case we assume. |
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
86fda30
to
d8a365c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🆗
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually blocking since more discussion is happening
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clarified, green light from my side
Summary
Allow to set the default view mode for public shares.
User shares allow the user to define it themself and saves it on their user config, but for public shares this is not available.
So let the sharer allow to define the default view mode.
Screen shots
New config option:
New behavior:
Bildschirmaufnahme_20250210_133103.webm
Checklist