Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable29] fix(AccountProperty): better validation of twitter and fediverse handles #50698

Merged
merged 5 commits into from
Feb 9, 2025
Merged

[stable29] fix(AccountProperty): better validation of twitter and fediverse handles #50698

merged 5 commits into from
Feb 9, 2025

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Feb 6, 2025 •
edited by susnux
Loading

Backport of #50678

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Remove all the empty commits

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added bug 3. to review Waiting for reviews feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.) labels Feb 6, 2025
@backportbot backportbot bot added this to the Nextcloud 29.0.12 milestone Feb 6, 2025
@susnux susnux force-pushed the backport/50678/stable29 branch from 57464c3 to 7615b37 Compare February 6, 2025 15:46
@susnux susnux marked this pull request as ready for review February 6, 2025 15:46
@susnux susnux force-pushed the backport/50678/stable29 branch 2 times, most recently from bc70835 to 8ed3e1f Compare February 7, 2025 13:58
@AndyScherzinger AndyScherzinger force-pushed the backport/50678/stable29 branch 2 times, most recently from 63b652f to eac3e4c Compare February 9, 2025 09:09
susnux added 5 commits February 9, 2025 13:46
@susnux
fix(AccountManager): Sanitize social media handles
4a7c883 
Ensure to only accept valid X and fediverse handles.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
fix(FediverseAction): Ensure valid fediverse links are generated
c4cc3f2 
Harden also for existing values of the profile.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
fix(provisioning_api): Correct limit for editUser
34bb825 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
fix(settings): Also sanitize fediverse and twitter handle in the fron…
44742d6 
…tend

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: Compile assets
43b95e1 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the backport/50678/stable29 branch from eac3e4c to 43b95e1 Compare February 9, 2025 12:46
@AndyScherzinger AndyScherzinger merged commit 87c0e74 into stable29 Feb 9, 2025
180 of 181 checks passed
@AndyScherzinger AndyScherzinger deleted the backport/50678/stable29 branch February 9, 2025 18:44
@Altahrim Altahrim mentioned this pull request Feb 11, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@susnux susnux susnux approved these changes

@Pytal Pytal Awaiting requested review from Pytal

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@susnux susnux

Labels
3. to review Waiting for reviews bug feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.)
Projects
None yet
Milestone
Nextcloud 29.0.12
Development

Successfully merging this pull request may close these issues.
2 participants
@AndyScherzinger @susnux