[stable29] enh: Fix display default expire date, add tests & tiny refactors #50693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfebe
reviewed
Feb 6, 2025
|
/backport to stable28 |
|
Needs to be backborted to 28 due modifications regard : #50192 |
|
artonge
approved these changes
Feb 6, 2025
5e50117 to
117e235
Compare
sorbaugh
approved these changes
Feb 11, 2025
117e235 to
1c677df
Compare
|
The backport seems incomplete with some missing imports and missed method renaming on a quick glance fyi @susnux Better to backport commits from the 30 backport no? |
1c677df to
cdc4c55
Compare
|
@Pytal I only fixed the compiled assets and csfixer issues, not verified the other commits. |
Signed-off-by: nfebe <fenn25.fn@gmail.com>
Since `ShareEntryLink` component is used to both create and display/list the share links, we should only set default expiration date on `share.expireDate` when we know is a new share. Otherwise, we overidding data from the backend. Signed-off-by: nfebe <fenn25.fn@gmail.com>
…reate share Signed-off-by: nfebe <fenn25.fn@gmail.com>
Signed-off-by: nfebe <fenn25.fn@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
cdc4c55 to
a444382
Compare
Alright 👍, I've resolved the issues using the commits from the 30 backport |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #50655
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.