-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enh: improve occ file:transfer-ownership logging #50663
base: master
Are you sure you want to change the base?
Conversation
77d0617
to
3b85ca0
Compare
3b85ca0
to
c00b9bd
Compare
@grnd-alt Please assign labels on new prs and provide a meaninful description, especially for reviewers that have not been involved before this will speed up review as it is easier to understand the context |
Also conventional commit message should be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current wording is not clear enough I think.
c18ed34
to
f8b7509
Compare
Signed-off-by: grnd-alt <github@belakkaf.net>
f8b7509
to
a1fd916
Compare
I’m afraid of the performance impact of this. |
When using occ file:transfer-ownership, we had issues reported that not all files where transferred when using s3 buckets as file storage.
This PR improves the logging of the occ command to inform users when not all files are transferred.