Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: template field title #50602

Merged
merged 2 commits into from
Feb 13, 2025
Merged

fix: template field title #50602

merged 2 commits into from
Feb 13, 2025

Conversation

elzody
Copy link
Contributor

@elzody elzody commented Jan 31, 2025 •
edited
Loading

⚠️ Tests are implemented in nextcloud/richdocuments#4448

Screenshots

Before

image

After

image

Checklist

@elzody elzody added the 3. to review Waiting for reviews label Jan 31, 2025
@elzody elzody self-assigned this Jan 31, 2025
@juliusknorr
Copy link
Member

Would it make sense to rather hide them? If they are not labeled, probably nobody would know what to insert

@elzody elzody marked this pull request as draft February 4, 2025 23:54
@elzody elzody added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Feb 4, 2025
@elzody elzody force-pushed the fix/template-field-title branch 2 times, most recently from ae69f09 to 7c15fc6 Compare February 7, 2025 19:36
@elzody elzody mentioned this pull request Feb 7, 2025
Open
@elzody elzody marked this pull request as ready for review February 7, 2025 19:49
@elzody elzody added 3. to review Waiting for reviews feature: templates and removed 2. developing Work in progress labels Feb 7, 2025
@elzody
Copy link
Contributor Author

elzody commented Feb 7, 2025

/backport to stable31

@elzody
Copy link
Contributor Author

elzody commented Feb 7, 2025

/backport to stable30

@elzody
Copy link
Contributor Author

elzody commented Feb 12, 2025

/compile

@elzody elzody force-pushed the fix/template-field-title branch 2 times, most recently from 55506ff to 5be4ba7 Compare February 12, 2025 21:19
@elzody
fix(template-filler): Hide template fields with unknown labels
7db90ef 
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
@elzody elzody force-pushed the fix/template-field-title branch from 5be4ba7 to a76fc66 Compare February 13, 2025 08:36
@elzody
chore: rebuild assets
729e278 
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
@elzody elzody force-pushed the fix/template-field-title branch from a76fc66 to 729e278 Compare February 13, 2025 08:40
max-nextcloud
max-nextcloud approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@elzody elzody merged commit 6e1d9a2 into master Feb 13, 2025
120 checks passed
@elzody elzody deleted the fix/template-field-title branch February 13, 2025 09:03
@backportbot backportbot bot mentioned this pull request Feb 13, 2025
Merged
2 tasks
@backportbot backportbot bot mentioned this pull request Feb 13, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@max-nextcloud max-nextcloud max-nextcloud approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner

Assignees

@elzody elzody

Labels
3. to review Waiting for reviews feature: templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Create templates with fields is shown even if fields have no title
3 participants
@elzody @juliusknorr @max-nextcloud