Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make early check if users filesystem have a mountpoint at /<user>/files #50470

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jan 27, 2025

Summary

Scanner checks both /<user> /<user>/files directories:

  1. If it exists on cache and on disk
  2. If it is writable
  3. If by chance path is overwritten with ext mountpoint

1 can still fail, if overwritten path of 3 is cached, and default dir doesn't exist, so 3 should be check first

UPD: another issue appeared while testing, added $relativePath to NotFoundException

Checklist

@Antreesy Antreesy added this to the Nextcloud 32 milestone Jan 27, 2025
@Antreesy Antreesy self-assigned this Jan 27, 2025
@Antreesy
Copy link
Contributor Author

Questions:

  • was there a reason to not check it first in initial PR?
  • will the periodic file scans (triggered by cron) work with that consideration?

@Antreesy Antreesy marked this pull request as draft January 28, 2025 14:37
@Antreesy Antreesy marked this pull request as ready for review February 10, 2025 08:49
…>/files/

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/49887/early-check-for-overwritten-home branch from a9fa476 to 4fc44d5 Compare February 10, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant