fix(oauth2): adjust db schemas when migrating from owncloud #50193
+96
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st3iny
commented
Jan 15, 2025
|
/backport! to stable29 |
2 tasks
ChristophWurst
approved these changes
Jan 20, 2025
nickvergessen
approved these changes
Jan 22, 2025
91c93e1 to
0fc1f08
Compare
|
/backport to stable30 |
|
/backport to stable31 |
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
0fc1f08 to
754a047
Compare
|
/backport to stable29 Let's recreate the backport as it was incomplete. |
skjnldsv
reviewed
Feb 6, 2025
| @@ -167,7 +166,7 @@ public static function getRepairSteps(): array { | |||
| \OC::$server->getUserManager(), | |||
| \OC::$server->getConfig() | |||
| ), | |||
| new MigrateOauthTables(\OC::$server->get(Connection::class)), | |||
| \OC::$server->get(MigrateOauthTables::class), | |||
There was a problem hiding this comment.
Suggested change
| \OC::$server->get(MigrateOauthTables::class), | |
| \OCP\Server::get(MigrateOauthTables::class), |
Next time 😉
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oc_oauth2_access_tokensis not adjusted properly and its data is not migrated correctly when migrating from ownCloud #50186Summary
See also #49075
This PR fixes two issues:
It does not aim to migrate legacy access tokens from ownCloud as this incurs a lot of work and tokens are only valid for an hour. So, it does not make sense as the migration window set by admins is probably longer than their lifetime anyway.
What I tested
mysqldump owncloud oc_oauth2_access_tokens oc_oauth2_refresh_tokens oc_oauth2_clientsoc_oauth2_access_tokens,oc_oauth2_refresh_tokensandoc_oauth2_clients).occ migrations:migrate oauth2 && occ maintenance:repairTODO
Checklist