Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Fix undefined "application" array key error #50081

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Jan 7, 2025

Summary

Fixes Undefined array key "application" being logged

Checklist

@Pytal Pytal added bug 3. to review Waiting for reviews labels Jan 7, 2025
@Pytal Pytal added this to the Nextcloud 31 milestone Jan 7, 2025
@Pytal Pytal requested review from skjnldsv and a team January 7, 2025 22:16
@Pytal Pytal self-assigned this Jan 7, 2025
@Pytal Pytal requested review from provokateurin and come-nc and removed request for a team January 7, 2025 22:16
@joshtrichards
Copy link
Member

Here too maybe?

p(!empty($_['pageTitle']) && $_['pageTitle'] !== $_['application'] ? $_['pageTitle'] . ' - ' : '');

Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isset() would be more corrext

@blizzz blizzz mentioned this pull request Jan 8, 2025
come-nc
come-nc previously requested changes Jan 9, 2025
core/templates/layout.public.php Outdated Show resolved Hide resolved
This was referenced Jan 14, 2025
This was referenced Jan 21, 2025
@blizzz blizzz mentioned this pull request Jan 29, 2025
1 task
@blizzz blizzz modified the milestones: Nextcloud 31, Nextcloud 32 Jan 29, 2025
@r0073rr0r

This comment was marked as resolved.

Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the fix/undefined-application-key branch from abb0676 to 5786fcb Compare February 12, 2025 00:10
@Pytal
Copy link
Member Author

Pytal commented Feb 12, 2025

/backport to stable31

@Pytal Pytal merged commit 167a78f into master Feb 12, 2025
190 checks passed
@Pytal Pytal deleted the fix/undefined-application-key branch February 12, 2025 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants