Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(preview): Do not try to parse M3U files as MP3 #50051

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

paulijar
Copy link
Contributor

@paulijar paulijar commented Jan 6, 2025

Summary

By default, the MP3 audio files get the mimetype audio/mpeg and the M3U and M3U8 playlist files get the mimetype audio/mpegurl. PreviewManager had such a problem that it registered the MP3 preview provider with a regular expression which matched also the M3U files. This caused an error message to be logged on the info (1) level for each M3U file every time a folder with such files was viewed: "Error while getting cover from mp3 file: File /path/to/some/playlist.m3u is not mpeg/audio!".

Checklist

By default, the MP3 audio files get the mimetype `audio/mpeg` and the M3U and
M3U8 playlist files get the mimetype `audio/mpegurl`. PreviewManager had such
a problem that it registered the MP3 preview provider with a regular
expression which matched also the M3U files. This caused an error message to
be logged on the info (1) level for each M3U file every time a folder with
such files was viewed: "Error while getting cover from mp3 file:
File /path/to/some/playlist.m3u is not mpeg/audio!".

Signed-off-by: Pauli Järvinen <pauli.jarvinen@gmail.com>
@AndyScherzinger AndyScherzinger added bug 3. to review Waiting for reviews labels Jan 7, 2025
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, though I wonder if we shouldn't make all patterns more strict by using ^ and $ everywhere. For example in the next line .* is used, but is unnecessary at the moment if the start and end don't matter.

@blizzz blizzz merged commit bd9a88b into master Jan 7, 2025
185 of 188 checks passed
@blizzz blizzz deleted the Fix/mp3_regex branch January 7, 2025 19:06
@blizzz
Copy link
Member

blizzz commented Jan 7, 2025

/backport to stable30

@blizzz blizzz added this to the Nextcloud 31 milestone Jan 7, 2025
@blizzz
Copy link
Member

blizzz commented Jan 7, 2025

/backport to stable29

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants