Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(occ): hide sensitive data while config:app:set #49826

Closed
wants to merge 1 commit into from
+1 −1
Closed

fix(occ): hide sensitive data while config:app:set #49826

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/Command/Config/App/SetConfig.php
View file
Original file line number Diff line number Diff line change
@@ -217,7 +217,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
"<info>Config value '%s' for app '%s' is now set to '%s', stored as %s in %s</info>",
$configName,
$appName,
$current['value'],
$current['sensitive'] ? '<sensitive>' : $current['value'],
$current['typeString'],
$current['lazy'] ? 'lazy cache' : 'fast cache'
)

Unchanged files with check annotations Beta

View file
lib/private/App/InfoParser.php
}
libxml_use_internal_errors(true);
$xml = simplexml_load_string(file_get_contents($file));

Check failure on line 38 in lib/private/App/InfoParser.php

GitHub Actions / static-code-analysis-security

TaintedFile 

lib/private/App/InfoParser.php:38:50: TaintedFile: Detected tainted file handling (see https://psalm.dev/255)
if ($xml === false) {
libxml_clear_errors();
View file
lib/private/AppFramework/Http/Dispatcher.php
}
$this->eventLogger->start('controller:' . get_class($controller) . '::' . $methodName, 'App framework controller execution');
$response = \call_user_func_array([$controller, $methodName], $arguments);

Check failure on line 200 in lib/private/AppFramework/Http/Dispatcher.php

GitHub Actions / static-code-analysis-security

TaintedCallable 

lib/private/AppFramework/Http/Dispatcher.php:200:37: TaintedCallable: Detected tainted text (see https://psalm.dev/243)
$this->eventLogger->end('controller:' . get_class($controller) . '::' . $methodName);
if (!($response instanceof Response)) {
View file
lib/private/Installer.php
private static function includeAppScript(string $script): void {
if (file_exists($script)) {
include $script;

Check failure on line 587 in lib/private/Installer.php

GitHub Actions / static-code-analysis-security

TaintedInclude 

lib/private/Installer.php:587:12: TaintedInclude: Detected tainted code passed to include or similar (see https://psalm.dev/251)
}
}
}
View file
lib/private/L10N/L10N.php
* @return bool
*/
protected function load(string $translationFile): bool {
$json = json_decode(file_get_contents($translationFile), true);

Check failure on line 215 in lib/private/L10N/L10N.php

GitHub Actions / static-code-analysis-security

TaintedFile 

lib/private/L10N/L10N.php:215:41: TaintedFile: Detected tainted file handling (see https://psalm.dev/255)
if (!\is_array($json)) {
$jsonError = json_last_error();
\OCP\Server::get(LoggerInterface::class)->warning("Failed to load $translationFile - json error code: $jsonError", ['app' => 'l10n']);
View file
lib/private/legacy/OC_App.php
\OC::$server->registerNamespace($app, $appNamespace);
if (file_exists($path . '/composer/autoload.php')) {
require_once $path . '/composer/autoload.php';

Check failure on line 115 in lib/private/legacy/OC_App.php

GitHub Actions / static-code-analysis-security

TaintedInclude 

lib/private/legacy/OC_App.php:115:17: TaintedInclude: Detected tainted code passed to include or similar (see https://psalm.dev/251)
} else {
\OC::$composerAutoloader->addPsr4($appNamespace . '\\', $path . '/lib/', true);
}