Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix group restriction regression #4972

Merged
merged 1 commit into from
May 19, 2017
Merged

Conversation

MorrisJobke
Copy link
Member

I also fixed the "never use one ID multiple times on a page". I will also create a backport to stable12.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@mention-bot
Copy link

@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @juliushaertl, @nickvergessen and @LukasReschke to be potential reviewers.

@MorrisJobke
Copy link
Member Author

@nursoda Could I ask you to test this?

@MorrisJobke
Copy link
Member Author

Backport for 12 is in #4973

@nursoda
Copy link

nursoda commented May 19, 2017

@MorrisJobke, is it OK to wait for the daily to be built? When is it built / what time tomorrow shall I test? I'm not a dev and I would rather use the updater app with the daily channel instead of git and build myself. Will I be able to switch back to beta channel and receive b5 once ready?

@juliusknorr juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 19, 2017
@LukasReschke LukasReschke merged commit 2e10812 into master May 19, 2017
@LukasReschke LukasReschke deleted the fix-group-restriction branch May 19, 2017 19:46
@MorrisJobke
Copy link
Member Author

MorrisJobke commented May 19, 2017

@nursoda You can also apply the patch by doing this:

cd /tmp
wget https://github.com/nextcloud/server/pull/4972.patch
cd /var/www/nextcloud
patch -p1 < /tmp/4972.patch

@nursoda
Copy link

nursoda commented May 19, 2017

Did that, works for me as expected / as it should. Thanks, that was quick :-)
NC12RC2 seems to have that fixed already, too. Great. Other oddities with RC2, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group restriction are not saved
5 participants