Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: get rid of denied notification when accept #48734

Merged
merged 3 commits into from
Oct 17, 2024
Merged

fix: get rid of denied notification when accept #48734

merged 3 commits into from
Oct 17, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Oct 16, 2024 •
edited
Loading

Summary

  • both accept and reject mark notification as processed, which ends up in dismissNotification()
  • during accept BG job is created, we check it on dismiss: if BG job is there, transfer was accepted, otherwise - denied
  • added an icon for notification
Before After
image image

TODO

  • ...

Checklist

@Antreesy Antreesy force-pushed the fix/45884/accept-notification branch 2 times, most recently from 56ed136 to b9c5fd4 Compare October 16, 2024 13:14
@Antreesy Antreesy self-assigned this Oct 16, 2024
@Antreesy Antreesy added this to the Nextcloud 31 milestone Oct 16, 2024
@Antreesy Antreesy marked this pull request as ready for review October 16, 2024 13:15
@Antreesy
fix: dismiss notification only after transfer bg job created
5be7641 
- do not create 'denied' notification if bg job exists

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix: do not duplicate existing entity
6e7c35d 
- this reverts 1e8048a

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix: add notification icon for transfer ownership
73b34bb 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/45884/accept-notification branch from b9c5fd4 to 73b34bb Compare October 16, 2024 15:32
@Antreesy Antreesy enabled auto-merge October 16, 2024 15:32
@nickvergessen nickvergessen merged commit 681ee75 into master Oct 17, 2024
176 of 177 checks passed
@nickvergessen nickvergessen deleted the fix/45884/accept-notification branch October 17, 2024 06:39
@Antreesy
Copy link
Contributor Author

/backport to stable30

@Antreesy
Copy link
Contributor Author

/backport to stable29

@Antreesy
Copy link
Contributor Author

/backport to stable28

@backportbot backportbot bot mentioned this pull request Oct 17, 2024
Merged
This was referenced Oct 17, 2024
Merged
Merged
@joshtrichards joshtrichards mentioned this pull request Nov 7, 2024
Closed
8 tasks
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@susnux susnux susnux approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review Waiting for reviews bug feature: files
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.
4 participants
@Antreesy @nickvergessen @susnux @juliusknorr