Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(S3ConfigTrait): Allow proxy field to take false #48016

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

provokateurin
Copy link
Member

@provokateurin provokateurin commented Sep 15, 2024

#47984

Summary

Can be false:

$this->proxy = $params['proxy'] ?? false;

Checklist

Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin added bug 3. to review Waiting for reviews labels Sep 15, 2024
@provokateurin provokateurin added this to the Nextcloud 31 milestone Sep 15, 2024
@provokateurin provokateurin requested review from miaulalala, a team, ArtificialOwl, artonge and come-nc and removed request for a team September 15, 2024 13:43
@provokateurin
Copy link
Member Author

/backport to stable30

@provokateurin
Copy link
Member Author

/backport to stable29

@provokateurin
Copy link
Member Author

/backport to stable28

@provokateurin provokateurin merged commit 3fe3f8d into master Sep 15, 2024
174 checks passed
@provokateurin provokateurin deleted the fix/s3configtrait/proxy-false branch September 15, 2024 17:16
Copy link

backportbot bot commented Sep 15, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/48016/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 7c1c02d6

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/48016/stable28

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@provokateurin
Copy link
Member Author

In stable28 the field is still in S3ConnectionTrait and not strongly typed, so no backport then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants