Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only write once to template instead of create/copy #47860

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Sep 10, 2024

Avoid triggering two file operations (create/copy) and write the template content on creation directly to also trigger a NodeWrittenEvent

Signed-off-by: Julius Knorr <jus@bitgrid.net>
@juliusknorr juliusknorr added bug 3. to review Waiting for reviews labels Sep 10, 2024
@juliusknorr juliusknorr added this to the Nextcloud 31 milestone Sep 10, 2024
@juliusknorr
Copy link
Member Author

/backport to stable30

@juliusknorr
Copy link
Member Author

/backport to stable29

@juliusknorr
Copy link
Member Author

/backport to stable28

@juliusknorr juliusknorr requested review from blizzz and mejo- September 10, 2024 07:46
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible.

Copy link
Member

@marcelklehr marcelklehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants