Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(files): Load limited depth tree #47122

Merged
merged 6 commits into from
Aug 8, 2024
Merged

feat(files): Load limited depth tree #47122

merged 6 commits into from
Aug 8, 2024

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Aug 8, 2024 •
edited
Loading

Resolves

Loads the folder tree at a limited depth instead of infinite depth as before which had performance issues

Requires

Checklist

@Pytal Pytal added this to the Nextcloud 30 milestone Aug 8, 2024
@Pytal Pytal self-assigned this Aug 8, 2024
@Pytal Pytal added the pending documentation This pull request needs an associated documentation update label Aug 8, 2024
@Pytal Pytal force-pushed the feat/limited-depth-tree branch from 4dd83f8 to 9803647 Compare August 8, 2024 04:25
@Pytal Pytal force-pushed the feat/limited-depth-tree branch 2 times, most recently from 76103bf to 35ae859 Compare August 8, 2024 04:43
@AndyScherzinger AndyScherzinger mentioned this pull request Aug 8, 2024
Merged
Altahrim
Altahrim approved these changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@Altahrim Altahrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHP part LGTM :)

@sorbaugh

This comment was marked as resolved.

Sign in to view
Pytal added 6 commits August 8, 2024 10:52
@Pytal
feat(files): Allow specifying path and depth for returned folder tree
e9083db 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
feat(files): Update openapi
36cf891 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
perf(files): Remove redundant call to get navigation
86459aa 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
feat(files): Add getter for all view configs
cfec6fc 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
feat: Load limited depth tree
44bc57b 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
chore: compile assets
36c23b2 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the feat/limited-depth-tree branch from 35ae859 to 36c23b2 Compare August 8, 2024 18:27
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 8, 2024
@Pytal Pytal enabled auto-merge August 8, 2024 18:28
@Pytal

This comment was marked as resolved.

Sign in to view
@Pytal Pytal merged commit 8c0bece into master Aug 8, 2024
167 of 168 checks passed
@Pytal Pytal deleted the feat/limited-depth-tree branch August 8, 2024 18:55
@Pytal Pytal removed the pending documentation This pull request needs an associated documentation update label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux left review comments

@Altahrim Altahrim Altahrim approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@sorbaugh sorbaugh sorbaugh approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@provokateurin provokateurin Awaiting requested review from provokateurin provokateurin is a code owner

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: files high performance 🚀 🍂 2024-Autumn
Projects
📁 Files team
Archived in project
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
6 participants
@Pytal @sorbaugh @susnux @Altahrim @skjnldsv @AndyScherzinger