Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable29] fix(files): Correctly create Nodes from WebDAV result in "recent"-view #46951

Merged
merged 3 commits into from
Aug 8, 2024
Merged

[stable29] fix(files): Correctly create Nodes from WebDAV result in "recent"-view #46951

merged 3 commits into from
Aug 8, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Aug 1, 2024 •
edited by susnux
Loading

Backport of #46918

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Remove all the empty commits

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added this to the Nextcloud 29.0.5 milestone Aug 1, 2024
@skjnldsv
Copy link
Member

skjnldsv commented Aug 1, 2024

apps/files/src/services/Files.ts needs a fix

@susnux susnux marked this pull request as ready for review August 8, 2024 12:12
@susnux susnux added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 8, 2024
@susnux susnux force-pushed the backport/46918/stable29 branch from 73767da to e89c73e Compare August 8, 2024 12:13
susnux
susnux approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased

@susnux susnux mentioned this pull request Aug 8, 2024
Merged
9 tasks
@susnux susnux enabled auto-merge August 8, 2024 12:22
@skjnldsv
Copy link
Member

skjnldsv commented Aug 8, 2024

image
oddly suspicious

susnux added 3 commits August 8, 2024 16:49
@susnux
fix(files): Correctly create Nodes from WebDAV result in "recent"-view
f7ee910 
The recent search works on a different remote URL so the source of the files were wrong,
because the remote url was included twice in the source.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
test: Add test for recent view
6524f0a 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: Compile assets
4c70619 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the backport/46918/stable29 branch from e89c73e to 4c70619 Compare August 8, 2024 14:50
@susnux
Copy link
Contributor

susnux commented Aug 8, 2024

Resolved

@susnux susnux merged commit 21f9fe8 into stable29 Aug 8, 2024
110 checks passed
@susnux susnux deleted the backport/46918/stable29 branch August 8, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@susnux susnux susnux approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@sorbaugh sorbaugh sorbaugh approved these changes

Assignees

@susnux susnux

Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: files regression
Projects
None yet
Milestone
Nextcloud 29.0.5
Development

Successfully merging this pull request may close these issues.
4 participants
@skjnldsv @susnux @AndyScherzinger @sorbaugh