Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: update border radius variables #46923

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Feat: update border radius variables #46923

merged 2 commits into from
Aug 1, 2024

Conversation

marcoambrosini
Copy link
Member

@marcoambrosini marcoambrosini commented Jul 31, 2024 •
edited
Loading

@susnux @ShGKme I've been asked to update and tidy this up, could you please tell me if this configuration makes sense to you? Also variable names

Screenshot 2024-07-31 at 17 23 52

@marcoambrosini marcoambrosini requested review from susnux and ShGKme July 31, 2024 15:23
susnux
susnux reviewed Jul 31, 2024
View reviewed changes
apps/theming/lib/Themes/DefaultTheme.php Outdated Show resolved Hide resolved
apps/theming/lib/Themes/DefaultTheme.php Outdated Show resolved Hide resolved
apps/theming/lib/Themes/DefaultTheme.php Outdated Show resolved Hide resolved
@susnux susnux added enhancement design Design, UI, UX, etc. 3. to review Waiting for reviews feature: theming labels Jul 31, 2024
@susnux susnux added this to the Nextcloud 30 milestone Jul 31, 2024
@marcoambrosini
Copy link
Member Author

marcoambrosini commented Aug 1, 2024 •
edited
Loading

@susnux @ShGKme about defult.css and defaulttheme.php, let's decide which file we write documentation in and move it all there?

@ShGKme
Copy link
Contributor

ShGKme commented Aug 1, 2024

@susnux @ShGKme about defult.css and defaulttheme.php, let's decide which file we write documentation in and move it all there?

Currently, they are documented in the documentation: https://docs.nextcloud.com/server/latest/developer_manual/html_css_design/css.html

@susnux
Copy link
Contributor

susnux commented Aug 1, 2024

@susnux @ShGKme about defult.css and defaulttheme.php, let's decide which file we write documentation in and move it all there?

As @ShGKme mentioned documentation should all go to the developer manual part of the docs, if you ask because of deprecation comments, then I would add those to both files to make it clearer for server developers.

@marcoambrosini marcoambrosini force-pushed the feat/update-border-radius-variables branch from bf2b8a0 to 23c0844 Compare August 1, 2024 13:39
@marcoambrosini marcoambrosini marked this pull request as ready for review August 1, 2024 13:40
@marcoambrosini
Copy link
Member Author

I added some docs to both files too for now because that's where most people are going to look

@susnux susnux added the pending documentation This pull request needs an associated documentation update label Aug 1, 2024
@susnux
Copy link
Contributor

susnux commented Aug 1, 2024

Looks good, please ensure that you add this to the app upgrade guide in the developer documentation as soon as possible so that app developers can adjust their apps best before Nextcloud 30 release :)

@marcoambrosini
Copy link
Member Author

@susnux I also updated the value of body container radius, that ok?

Antreesy
Antreesy approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legit

@marcoambrosini marcoambrosini force-pushed the feat/update-border-radius-variables branch from d7c897c to fa8f6d0 Compare August 1, 2024 14:19
@blizzz blizzz mentioned this pull request Aug 1, 2024
Merged
marcoambrosini and others added 2 commits August 1, 2024 21:36
@marcoambrosini @susnux
Feat: update border radius variables
92e27a2 
Signed-off-by: Marco Ambrosini <marcoambrosini@proton.me>
@marcoambrosini @susnux
feat(theming): Update value of body container radius
e10f0dc 
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Marco Ambrosini <marcoambrosini@proton.me>
@susnux susnux force-pushed the feat/update-border-radius-variables branch from fa8f6d0 to e10f0dc Compare August 1, 2024 19:41
@marcoambrosini marcoambrosini merged commit d58fc0f into master Aug 1, 2024
173 checks passed
@marcoambrosini marcoambrosini deleted the feat/update-border-radius-variables branch August 1, 2024 22:26
@Altahrim Altahrim mentioned this pull request Aug 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@Antreesy Antreesy Antreesy approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees
No one assigned
Labels
3. to review Waiting for reviews design Design, UI, UX, etc. enhancement feature: theming pending documentation This pull request needs an associated documentation update
Projects
🖍 Design team
Archived in project
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
4 participants
@marcoambrosini @ShGKme @susnux @Antreesy